There are a lot of discounts and services available to veterans, but even more for members of the American Legion.  These discounts and services will repay your membership dues many times over.  Here are some of them.

Banking

USAA Financial and Insurance Services.  An American Legion preferred provider (includes insurance for home, auto, and life).